refactor: remove @angular-devkit/core logger and its dependencies from the e2e runner#32736
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Mar 10, 2026
Merged
Conversation
…rom the e2e runner This logger was unused.
alan-agius4
added
the
target: patch
alan-agius4
added
the
action: review
clydin
approved these changes
Mar 10, 2026
alan-agius4
added
action: merge
Collaborator
Author
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the e2e runner by removing the unused @angular-devkit/core logger and its associated dependencies. The changes are clean and effectively remove the dead code from tests/e2e_runner.ts and the corresponding build configurations in tests/BUILD.bazel. The removal of an unused rollup plugin dependency is also a good cleanup. The changes are correct and improve code maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This logger was unused.